Fix GH-3353 incorrect function tag linking #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase to solve conflicts? |
|
If you don't mind, I'll wait for #126 to be merged before rebasing. |
a2a4589 to
c3759b9
Compare
|
Rebased and ready for review. |
Girgias
reviewed
May 21, 2024
Girgias
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes php/doc-en#3353.
When the list of
refentrys (functions and methods) is retrieved from the indexing database the characters_,::and->in their names were replaced by-before storing them in the array$refinFormat.php. As this array is used to generate the links to and the index list of functions/methods, functions and methods with the same name after replacing the before mentioned characters (e.g.finfo_buffer()/finfo::buffer(),finfo_file()/finfo::file(), etc.) were overwriting each other's reference entries in memory (in the$refarray).Fix this by not replacing the above listed characters.