Add SensitiveParameterValue documentation #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
commented
Jan 10, 2023
Comment on lines
+77
to
+79
| &language.predefined.sensitiveparametervalue.construct; | ||
| &language.predefined.sensitiveparametervalue.debuginfo; | ||
| &language.predefined.sensitiveparametervalue.getvalue; |
There was a problem hiding this comment.
FWIW: It's not great that no automated entity file is generated for classes outside of reference/ :-(
There was a problem hiding this comment.
Indeed. Should be possible to also generate entities.*.xml for language/.
8720844 to
4fe34a2
Compare
cmb69
approved these changes
Jan 11, 2023
Comment on lines
+77
to
+79
| &language.predefined.sensitiveparametervalue.construct; | ||
| &language.predefined.sensitiveparametervalue.debuginfo; | ||
| &language.predefined.sensitiveparametervalue.getvalue; |
There was a problem hiding this comment.
Indeed. Should be possible to also generate entities.*.xml for language/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts (long description for
getValue()and general refining) are still missing, but having something is better than having nothing and these parts should allows folks to build onto it.