Make the static cache persist for the entire life of the PHP process, to reduce HTTP requests for unmodified metadata #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenaproxima
commented
Jul 13, 2024
| @@ -0,0 +1,24 @@ | |||
| <?php | |||
|
|
|||
| $file = __DIR__ . $_SERVER['SCRIPT_NAME']; | |||
There was a problem hiding this comment.
This file was added to support the functional testing. PHP's built-in server doesn't natively handle If-Modified-Since headers, so I had to implement that here.
|
@tedbow is on another project, so I'm merging this for now and he will review the changes before the next tag is cut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, look! I found a way to reduce the number of network requests we make. :) This makes the static cache loader more aggressive, and persists it for the entire life of the PHP process, regardless of how often Composer decides to reset itself internally.
Testing with
php-tuf/drupal-projectdoesn't show a major performance difference, but this definitely reduces the amount of network-bound I/O, which is certainly good. You can tell by comparing the logs -- testing against this branch, you'll see far fewer requests for TUF metadata that return a304response code.