Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Server::resetState method #196

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Add Server::resetState method #196

merged 2 commits into from
Feb 5, 2018

Conversation

laszlof
Copy link
Contributor

@laszlof laszlof commented Jan 24, 2018

Add functionality to reset the state of a VM.

Copy link
Collaborator

@haphan haphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @laszlof. Only a few minor changes needed.

*/
public function resetState()
{
$response = $this->execute($this->api->resetServerState(), [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove $response

@@ -15,6 +15,19 @@ public function urlId(string $type): array
]);
}

public function osResetState(): array
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use resetState

'path' => 'servers/{id}/action',
'params' => [
'id' => $this->params->urlId('server'),
'resetState' => $this->params->osResetState()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use resetState

@haphan
Copy link
Collaborator

haphan commented Feb 5, 2018

@laszlof I left some minor change requests :)

@laszlof
Copy link
Contributor Author

laszlof commented Feb 5, 2018 via email

@laszlof
Copy link
Contributor Author

laszlof commented Feb 5, 2018

@haphan The issues have been corrected.

@haphan haphan merged commit 40f7ec9 into php-opencloud:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants