Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise documentation for retry mechanism #295

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Feb 17, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets mentioned in php-http/httplug#168
License MIT

What's in this PR?

This PR adds the documentation for php-http/httplug#168

@dbu
Copy link
Contributor

dbu commented Feb 21, 2022

thanks for the documentation! i wonder if it makes sense to have the full example here in the doc, or if we better just mention it is possible and then link to the retry plugin? it is quite a bit of code here, and when using httplug, using the retry plugin would make more sense than implementing that code yourself...

@ezimuel
Copy link
Contributor Author

ezimuel commented Feb 21, 2022

@dbu we should definitely link the retry plugin when it will be ready but I also think that the example in the doc can be helpful for understanding the async retry mechanism, using a chain of then().

@dbu dbu merged commit ab70f56 into php-http:master Apr 29, 2022
@dbu
Copy link
Contributor

dbu commented Apr 29, 2022

that went under. thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants