[dbal] Consumer never fetches messages ordered by published time

php-enqueue · Jan 22, 2018 · 91ae4cc · 91ae4cc
1 parent b0b1ad3
commit 91ae4cc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/pkg/dbal/DbalContext.php b/pkg/dbal/DbalContext.php
@@ -178,7 +178,7 @@ public function createDataBaseTable()
         $table->addColumn('properties', 'text', ['notnull' => false]);
         $table->addColumn('redelivered', 'boolean', ['notnull' => false]);
         $table->addColumn('queue', 'string');
-        $table->addColumn('priority', 'smallint');
+        $table->addColumn('priority', 'smallint', ['notnull' => false]);
         $table->addColumn('delayed_until', 'integer', ['notnull' => false]);
         $table->addColumn('time_to_live', 'integer', ['notnull' => false]);
 

diff --git a/pkg/dbal/DbalMessage.php b/pkg/dbal/DbalMessage.php
@@ -52,7 +52,7 @@ public function __construct($body = '', array $properties = [], array $headers =
         $this->properties = $properties;
         $this->headers = $headers;
         $this->redelivered = false;
-        $this->priority = 0;
+        $this->priority = null;
         $this->deliveryDelay = null;
     }
 

diff --git a/pkg/dbal/Tests/DbalContextTest.php b/pkg/dbal/Tests/DbalContextTest.php
@@ -59,7 +59,7 @@ public function testShouldCreateMessage()
         $this->assertEquals('body', $message->getBody());
         $this->assertEquals(['pkey' => 'pval'], $message->getProperties());
         $this->assertEquals(['hkey' => 'hval'], $message->getHeaders());
-        $this->assertSame(0, $message->getPriority());
+        $this->assertNull($message->getPriority());
         $this->assertFalse($message->isRedelivered());
     }
 

diff --git a/pkg/dbal/Tests/DbalMessageTest.php b/pkg/dbal/Tests/DbalMessageTest.php
@@ -27,11 +27,11 @@ public function testCouldBeConstructedWithOptionalArguments()
         $this->assertSame(['fooHeader' => 'fooHeaderVal'], $message->getHeaders());
     }
 
-    public function testShouldSetPriorityToZeroInConstructor()
+    public function testShouldSetPriorityToNullInConstructor()
     {
         $message = new DbalMessage();
 
-        $this->assertSame(0, $message->getPriority());
+        $this->assertNull($message->getPriority());
     }
 
     public function testShouldSetDelayToNullInConstructor()