Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught ReferenceError: photopress is not defined #2

Closed
taliesinpenbardd opened this issue Sep 28, 2020 · 1 comment
Closed

Uncaught ReferenceError: photopress is not defined #2

taliesinpenbardd opened this issue Sep 28, 2020 · 1 comment

Comments

@taliesinpenbardd
Copy link
Contributor

Hey all,
Wonderful idea, this plugin!
However, I get a JS error in the console, who says:

Uncaught ReferenceError: photopress is not defined
    <anonymous> http://stulamu.test/wp-content/plugins/photopress/modules/slideshow/assets/js/slideshow.js:10

Using DebugPress, I can see the "photopress-slideshow" and "photopress-masonry" scripts are presented BEFORE the "photopress" script, but that could also be a quirk in the DebugPress presentation.

Environment:
Valet (MacOS), PHP 7.4
WP 5.5.1
Photopress 1.4.0
Gallery is in "Justified" mode
taliesinpenbardd added a commit to taliesinpenbardd/photopress-plugin that referenced this issue Sep 28, 2020
@taliesinpenbardd
Modified wp_enqueue_script()
7c6a766 
Ensure the script is loaded after photopress.js, photopress-dev#2
@taliesinpenbardd taliesinpenbardd mentioned this issue Sep 28, 2020
Merged
@padams
Copy link
Collaborator

padams commented Sep 28, 2020

Nice catch on these. thanks.

@padams padams closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@padams @taliesinpenbardd