Merge pull request #445 from nmichaud/selection-overlay

Don't do header highlighting when selectionMode is row or column
phosphorjs · Oct 26, 2019 · 5d86cf8 · 5d86cf8
2 parents 6ee4937 + 9c0b56f
commit 5d86cf8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/datagrid/src/datagrid.ts b/packages/datagrid/src/datagrid.ts
@@ -4496,8 +4496,8 @@ class DataGrid extends Widget {
     // Fetch the selection model.
     let model = this._selectionModel;
 
-    // Bail early if there are no selections.
-    if (!model || model.isEmpty) {
+    // Bail early if there are no selections or if the selectionMode is the entire column.
+    if (!model || model.isEmpty || model.selectionMode == 'column') {
       return;
     }
 
@@ -4597,8 +4597,8 @@ class DataGrid extends Widget {
     // Fetch the selection model.
     let model = this._selectionModel;
 
-    // Bail early if there are no selections.
-    if (!model || model.isEmpty) {
+    // Bail early if there are no selections or if the selectionMode is the entire row
+    if (!model || model.isEmpty || model.selectionMode == 'row') {
       return;
     }