Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Update PAYLOAD.md fixes #2449 #2602

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Update PAYLOAD.md fixes #2449 #2602

merged 2 commits into from
Oct 29, 2018

Conversation

ramon-dejesus
Copy link
Contributor

Creates PR in response to #2449

Description

I created a PR in reponse to @macdonst in issue #2449

Related Issue

#2449

Motivation and Context

This change provides information to Push Plugin developers that are having issues with iOS silent pushes not arriving in foreground.

How Has This Been Tested?

I tested this fix on iOS 12.1 and confirmed that it works.

Screenshots (if appropriate):

Types of changes

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@macdonst macdonst merged commit 2f45c0d into phonegap:master Oct 29, 2018
@macdonst
Copy link
Member

@rldejesusm thanks for the PR

@andreszs
Copy link
Contributor

Thank you for the PR. To show comments inside the JSON sample code properly, better use PHP format for syntax highlighting in this block. This way comments inside JSON will be displayed properly, with dark green foreground, because now they are shown like this:

image

@lock
Copy link

lock bot commented Nov 28, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants