Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Update TYPESCRIPT.md #2596

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Update TYPESCRIPT.md #2596

merged 1 commit into from
Oct 23, 2018

Conversation

simonhaenisch
Copy link
Contributor

Description

The type declarations for this plugin come with the package now, @types/phonegap-plugin-push has been deprecated.

The example also didn't show how to actually import the types.

Related Issue

Nope.

Motivation and Context

I needed to use this plugin in a Typescript project and saw that this doc was outdated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fredgalvao fredgalvao merged commit 07b8d7f into phonegap:master Oct 23, 2018
@fredgalvao
Copy link
Collaborator

Thanks for your time and for the contribution!

@fredgalvao
Copy link
Collaborator

#2297 and #1536 have been the target issue for a while, and I'll link this here for consistency.

@simonhaenisch simonhaenisch deleted the patch-1 branch October 23, 2018 03:35
@lock
Copy link

lock bot commented Nov 22, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants