clearAll notifications on Android if count zero when in background #2521
Conversation
| if (badgeCount == 0) { | ||
| NotificationManager mNotificationManager = (NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE); | ||
| mNotificationManager.cancelAll(); | ||
| } |
There was a problem hiding this comment.
@chriscant okay, I haven't had a chance to test yet but what I see looks good. Let me confirm my thinking.
if count >= 0 then set the badge number, which is the current behaviour
if count == 0 then clear all the notifications which is new behaviour
if count is not provided in the push payload then extractBadgeCount returns -1 and neither of the above two statements are true so we get the existing behaviour.
So the only time the behaviour of the plugin changes is if someone explicitly sets the count/badge to 0 in the push payload? Note, that seems to be the best way forward.
There was a problem hiding this comment.
That's my understanding, yes.
Note that if a title or message is also supplied then a new notification is created, as per current behaviour.
And the event handler is still called, as per current behaviour.
There was a problem hiding this comment.
Sweet that's what I was hoping for 🤞 I'll be able to test soon.
|
@chriscant thanks for the PR. I finally got a chance to test and merge. |
|
This thread has been automatically locked. |
Description
Update FCMService notification handler for Android when in background so count==0 initially clears all existing notifications, closely matching iOS functionality. Note that iOS only clears notifications if the count has gone down eg from 1 to 0. Notifications are not cleared if count not given.
Update payload documentation with note to explain behaviour on Android and iOS.
Please change or move the note if required.
Related Issue
#2520
Motivation and Context
If notification(s) are no longer relevant then they should be removed, even if app not running.
This can be signalled by setting badge count to zero.
This was not happening in Android.
Note that after all current notifications have been cleared (a) a new notification will be created if a message or title is given and (b) the notification event handlers are called if the app is running.
How Has This Been Tested?
Tested by sending notifications with different payloads to Android and iOS devices.
Types of changes
The change could be viewed as one or all of these types:
Checklist: