Set get badge count android #1644
Conversation
| @@ -59,6 +59,7 @@ | |||
| public static final String CONTENT_AVAILABLE = "content-available"; | |||
| public static final String TOPICS = "topics"; | |||
| public static final String SET_APPLICATION_ICON_BADGE_NUMBER = "setApplicationIconBadgeNumber"; | |||
| public static final String GET_APPLICATION_ICON_BADGE_NUMBER = "getApplicationIconBadgeNumber"; | |||
There was a problem hiding this comment.
Minor point, fix the indentation here.
|
|
||
| int badgeCount = getApplicationIconBadgeNumber(getApplicationContext()); | ||
| PluginResult pluginResult = new PluginResult(PluginResult.Status.OK, badgeCount); | ||
| pluginResult.setKeepCallback(true); |
There was a problem hiding this comment.
Why do you need to keep the callback around? Once you return the badge count you should be done.
| callbackContext.sendPluginResult(pluginResult); | ||
|
|
||
| } | ||
| }); |
There was a problem hiding this comment.
The above can probably be written as:
} else if (GET_APPLICATION_ICON_BADGE_NUMBER.equals(action)) {
cordova.getThreadPool().execute(new Runnable() {
public void run() {
Log.v(LOG_TAG, "getApplicationIconBadgeNumber");
callbackContext.success(getApplicationIconBadgeNumber(getApplicationContext()));
}
});
| public static int getApplicationIconBadgeNumber(Context context){ | ||
| SharedPreferences settings = context.getSharedPreferences("badge", Context.MODE_PRIVATE); | ||
| int badge = settings.getInt("badge", 0); | ||
| return badge; |
There was a problem hiding this comment.
No need to create a temporary value here unless you are going to log the badge number. You can just return the value of settings.getInt().
| //in order for plugin cordova-plugin-badge to retrive it correctly | ||
| SharedPreferences.Editor editor = context.getSharedPreferences("badge", Context.MODE_PRIVATE).edit(); | ||
| editor.putInt("badge", 0); | ||
| editor.apply(); |
There was a problem hiding this comment.
There is some duplicate code here in the if/else block. Why not move the setting of the badge number to after the if/else and do something like:
SharedPreferences.Editor editor = context.getSharedPreferences("badge", Context.MODE_PRIVATE).edit();
editor.putInt("badge", badge > 0 ? badge : 0);
editor.apply();
There was a problem hiding this comment.
Or Math.max(badge, 0), for clarity.
|
sorry there is still a problem, gonna fix it soon |
|
Alright, sorry for the delay and for the mistakes, we were in a rush so we didn't pay much attention to details. |
| public void run() { | ||
| Log.v(LOG_TAG, "getApplicationIconBadgeNumber"); | ||
|
|
||
| callbackContext.success(getApplicationIconBadgeNumber(getApplicationContext())); |
There was a problem hiding this comment.
Indent one more space and remove extraneous lines before and after.
| * Retrives badge count from SharedPreferences | ||
| */ | ||
| public static int getApplicationIconBadgeNumber(Context context){ | ||
| SharedPreferences settings = context.getSharedPreferences("badge", Context.MODE_PRIVATE); |
There was a problem hiding this comment.
Use BADGE constant instead of "badge" string on this line and next line.
| public static void setApplicationIconBadgeNumber(Context context, int badgeCount) { | ||
| if (badgeCount > 0) { |
There was a problem hiding this comment.
This block you deleted should not be removed. Please add it back.
| } else { | ||
| ShortcutBadger.removeCount(context); | ||
| } | ||
| SharedPreferences.Editor editor = context.getSharedPreferences("badge", Context.MODE_PRIVATE).edit(); |
There was a problem hiding this comment.
Use BADGE constant instead of "badge" string on this and next line.
|
@rastafan still some issues in the PR. |
|
Sorry for the delay, I hope everything's alright now :) |
|
@rastafan awesome! I've just merged the changes. Thanks for the PR. Sorry for the delay, I was on vacation last week. |
|
This thread has been automatically locked. |
Added getApplicationIconBadgeNumber method for Android
Description
Added getApplicationIconBadgeNumber method for retrieving badge count in Android using SharedPreferences to store it
Related Issue
#1639
Motivation and Context
Made to add support to cordova-plugin-badge, which was unable to retrive badge number set by phonegap-plugin-push
Types of changes
Checklist: