Use value typecasted by super class

phokz · May 22, 2013 · eacb5c5 · eacb5c5
1 parent 3bfe808
commit eacb5c5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/lib/snmp/varbind.rb b/lib/snmp/varbind.rb
@@ -109,8 +109,8 @@ def to_oid
   class Integer32 < Integer
     def initialize(value)
       super(value)
-      raise ArgumentError, "Out of range: #{value}" if value < -2147483648
-      raise ArgumentError, "Out of range: #{value}" if value > 2147483647
+      raise ArgumentError, "Out of range: #{@value}" if @value < -2147483648
+      raise ArgumentError, "Out of range: #{@value}" if @value > 2147483647
     end
   end
 
@@ -336,8 +336,8 @@ def parse_string(ip_string)
   class UnsignedInteger < Integer
     def initialize(value)
       super(value)
-      raise ArgumentError, "Negative integer invalid: #{value}" if value < 0
-      raise ArgumentError, "Out of range: #{value}" if value > 4294967295
+      raise ArgumentError, "Negative integer invalid: #{@value}" if @value < 0
+      raise ArgumentError, "Out of range: #{@value}" if @value > 4294967295
     end
 
     def self.decode(value_data)
@@ -428,8 +428,8 @@ def asn1_type
 
     def initialize(value)
       super(value)
-      raise ArgumentError, "Negative integer invalid: #{value}" if value < 0
-      raise ArgumentError, "Out of range: #{value}" if value > 18446744073709551615
+      raise ArgumentError, "Negative integer invalid: #{@value}" if @value < 0
+      raise ArgumentError, "Out of range: #{@value}" if @value > 18446744073709551615
     end
 
     def encode

diff --git a/test/test_varbind.rb b/test/test_varbind.rb
@@ -211,6 +211,11 @@ def test_integer_create
     assert_not_nil(i.asn1_type)
   end
 
+  def test_integer_create_from_string
+    i = Integer.new("12345")
+    assert_equal(12345, i.to_i)
+  end
+
   def test_integer_decode
     i = Integer.decode("09")
     assert_equal(12345, i.to_i)