Add SGML#fragment for marking selective rendering blocks
#842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGML#fragment for marking selective rendering blocks
baae289 to
6548252
Compare
It is not currently cache aware
6548252 to
bc9d346
Compare
joeldrapper
reviewed
Feb 4, 2025
lib/phlex/context.rb
Outdated
| attr_reader :fragments, :fragment_depth, :view_context | ||
|
|
||
| def target_fragments(fragments) | ||
| @fragments = fragments.to_h { |it| [it, true].freeze } |
There was a problem hiding this comment.
Let’s just use a set here unless there’s a big performance impact.
lib/phlex/sgml.rb
Outdated
Comment on lines
180
to
184
| def fragment(name) | ||
| @_context.begin_target(name) | ||
| yield | ||
| @_context.end_target(name) | ||
| end |
There was a problem hiding this comment.
This method should return nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGML#fragmentmethod