Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EchoTask] Fixed type handling. #1217

Merged
merged 1 commit into from
Dec 23, 2019
Merged

[EchoTask] Fixed type handling. #1217

merged 1 commit into from
Dec 23, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Dec 22, 2019

Fixed bool assumption for not typed hinted setters.
Related to #1201

@siad007 siad007 added the defect label Dec 22, 2019
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Dec 22, 2019
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #1217 into master will not change coverage.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1217   +/-   ##
=========================================
  Coverage     47.39%   47.39%           
  Complexity     9964     9964           
=========================================
  Files           506      506           
  Lines         24485    24485           
=========================================
  Hits          11604    11604           
  Misses        12881    12881
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/EchoTask.php 77.58% <70%> (ø) 20 <6> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abdc85d...97fe117. Read the comment docs.

@@ -116,27 +116,27 @@ protected function getFilesetsMsg()
*
* @param $file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the type here.

{
$this->file = (string) $file;
$this->file = $file;
}

/**
* setter for level
*
* @param $level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the type here.

{
$this->level = (string) $level;
$this->level = $level;
}

/**
* setter for append
*
* @param $append
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the type here.

@@ -146,7 +146,7 @@ public function setAppend($append)
*
* @param $msg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the type here.

@@ -156,18 +156,18 @@ public function setMsg($msg)
*
* @param $msg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the type here.

{
$this->msg = (string) $msg;
$this->msg = $msg;
}

/**
* Supporting the <echo>Message</echo> syntax.
*
* @param $msg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the type here.

@siad007
Copy link
Member Author

siad007 commented Dec 23, 2019

@mimmi20 thx for your review, but your requests are actual not the scope of this bug fix. Please open a new ticket or make a contribution.

@siad007 siad007 merged commit b4501c7 into master Dec 23, 2019
@siad007 siad007 deleted the siad007-patch-1 branch December 23, 2019 21:08
@siad007 siad007 mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants