-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EchoTask] Fixed type handling. #1217
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1217 +/- ##
=========================================
Coverage 47.39% 47.39%
Complexity 9964 9964
=========================================
Files 506 506
Lines 24485 24485
=========================================
Hits 11604 11604
Misses 12881 12881
Continue to review full report at Codecov.
|
@@ -116,27 +116,27 @@ protected function getFilesetsMsg() | |||
* | |||
* @param $file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the type here.
{ | ||
$this->file = (string) $file; | ||
$this->file = $file; | ||
} | ||
|
||
/** | ||
* setter for level | ||
* | ||
* @param $level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the type here.
{ | ||
$this->level = (string) $level; | ||
$this->level = $level; | ||
} | ||
|
||
/** | ||
* setter for append | ||
* | ||
* @param $append |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the type here.
@@ -146,7 +146,7 @@ public function setAppend($append) | |||
* | |||
* @param $msg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the type here.
@@ -156,18 +156,18 @@ public function setMsg($msg) | |||
* | |||
* @param $msg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the type here.
{ | ||
$this->msg = (string) $msg; | ||
$this->msg = $msg; | ||
} | ||
|
||
/** | ||
* Supporting the <echo>Message</echo> syntax. | ||
* | ||
* @param $msg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the type here.
@mimmi20 thx for your review, but your requests are actual not the scope of this bug fix. Please open a new ticket or make a contribution. |
Fixed bool assumption for not typed hinted setters.
Related to #1201