Move another bunch of optional tasks

phingofficial · Feb 1, 2021 · 398f479 · 398f479
1 parent b7649a2
commit 398f479
Show file tree

Hide file tree

Showing 20 changed files with 89 additions and 58 deletions.
diff --git a/etc/default.tasks.properties b/etc/default.tasks.properties
@@ -89,31 +89,31 @@ xmlproperty=Phing\Task\System\XmlPropertyTask
 package-as-path=Phing\Task\System\PackageAsPathTask
 
 ; "ext" tasks
-mail=phing.tasks.ext.MailTask
+mail=Phing\Task\Optional\MailTask
+xmllint=Phing\Task\Optional\XmlLintTask
+jsllint=Phing\Task\Optional\JslLintTask
+phpcs=Phing\Task\Optional\PhpCSTask
+patch=Phing\Task\Optional\PatchTask
+rST=Phing\Task\Optional\RSTTask
+parallel=Phing\Task\Optional\ParallelTask
+filesync=Phing\Task\Optional\FileSyncTask
+composer=Phing\Task\Optional\ComposerTask
+notifysend=Phing\Task\Optional\NotifySendTask
+growlnotify=Phing\Task\Optional\GrowlNotifyTask
+wikipublish=Phing\Task\Optional\WikiPublishTask
+stopwatch=Phing\Task\Optional\StopwatchTask
+phpstan=phing.tasks.ext.PHPStanTask
 phpunit=phing.tasks.ext.phpunit.PHPUnitTask
 phpunitreport=phing.tasks.ext.phpunit.PHPUnitReportTask
-xmllint=phing.tasks.ext.XmlLintTask
-jsllint=phing.tasks.ext.JslLintTask
-phpcs=phing.tasks.ext.PhpCSTask
 phpcpd=phing.tasks.ext.phpcpd.PHPCPDTask
 phploc=phing.tasks.ext.phploc.PHPLocTask
 phpmd=phing.tasks.ext.phpmd.PHPMDTask
 phpdepend=phing.tasks.ext.pdepend.PhpDependTask
-filesync=phing.tasks.ext.FileSyncTask
-patch=phing.tasks.ext.PatchTask
 s3get=phing.tasks.ext.Service.Amazon.S3.S3GetTask
 s3put=phing.tasks.ext.Service.Amazon.S3.S3PutTask
 zendguardencode=phing.tasks.ext.zendguard.ZendGuardEncodeTask
 zendguardlicense=phing.tasks.ext.zendguard.ZendGuardLicenseTask
-rST=phing.tasks.ext.RSTTask
 sass=phing.tasks.ext.sass.SassTask
-parallel=phing.tasks.ext.ParallelTask
 symfonyconsole=phing.tasks.ext.SymfonyConsole.SymfonyConsoleTask
-composer=phing.tasks.ext.ComposerTask
-notifysend=phing.tasks.ext.NotifySendTask
-growlnotify=phing.tasks.ext.GrowlNotifyTask
-wikipublish=phing.tasks.ext.WikiPublishTask
-stopwatch=phing.tasks.ext.StopwatchTask
 sonar=phing.tasks.ext.sonar.SonarTask
 hipchat=phing.tasks.ext.hipchat.HipchatTask
-phpstan=phing.tasks.ext.PHPStanTask
diff --git a/classes/phing/tasks/ext/ComposerTask.php → src/Phing/Task/Optional/ComposerTask.php b/classes/phing/tasks/ext/ComposerTask.php → src/Phing/Task/Optional/ComposerTask.php
@@ -17,13 +17,16 @@
  * <http://phing.info>.
  */
 
+namespace Phing\Task\Optional;
+
 use Phing\Exception\BuildException;
 use Phing\Io\FileSystem;
 use Phing\Io\IOException;
 use Phing\Project;
 use Phing\Task;
 use Phing\Type\Commandline;
 use Phing\Type\CommandlineArgument;
+use SplFileInfo;
 
 /**
  * Composer Task

diff --git a/classes/phing/tasks/ext/FileSyncTask.php → src/Phing/Task/Optional/FileSyncTask.php b/classes/phing/tasks/ext/FileSyncTask.php → src/Phing/Task/Optional/FileSyncTask.php
@@ -17,6 +17,8 @@
  * <http://phing.info>.
  */
 
+namespace Phing\Task\Optional;
+
 use Phing\Exception\BuildException;
 use Phing\Project;
 use Phing\Task;
@@ -346,7 +348,7 @@ public function getCommand()
     /**
      * Returns an error message based on a given error code.
      *
-     * @param  int $code Error code
+     * @param int $code Error code
      * @return null|string
      */
     public function getErrorMessage($code)
@@ -381,7 +383,7 @@ public function getErrorMessage($code)
     /**
      * Sets the path to the rsync command.
      *
-     * @param  string $path
+     * @param string $path
      * @return void
      */
     public function setRsyncPath($path)
@@ -392,7 +394,7 @@ public function setRsyncPath($path)
     /**
      * Sets the isRemoteConnection property.
      *
-     * @param  boolean $isRemote
+     * @param boolean $isRemote
      * @return void
      */
     protected function setIsRemoteConnection($isRemote)
@@ -403,7 +405,7 @@ protected function setIsRemoteConnection($isRemote)
     /**
      * Sets the source directory.
      *
-     * @param  string $dir
+     * @param string $dir
      * @return void
      */
     public function setSourceDir($dir)
@@ -414,7 +416,7 @@ public function setSourceDir($dir)
     /**
      * Sets the command options.
      *
-     * @param  string $options
+     * @param string $options
      * @return void
      */
     public function setOptions($options)
@@ -426,7 +428,7 @@ public function setOptions($options)
      * Sets the destination directory. If the option remotehost is not included
      * in the build.xml file, rsync will point to a local directory instead.
      *
-     * @param  string $dir
+     * @param string $dir
      * @return void
      */
     public function setDestinationDir($dir)
@@ -437,7 +439,7 @@ public function setDestinationDir($dir)
     /**
      * Sets the remote host.
      *
-     * @param  string $host
+     * @param string $host
      * @return void
      */
     public function setRemoteHost($host)
@@ -449,7 +451,7 @@ public function setRemoteHost($host)
      * Specifies the user to log in as on the remote machine. This also may be
      * specified in the properties file.
      *
-     * @param  string $user
+     * @param string $user
      * @return void
      */
     public function setRemoteUser($user)
@@ -462,7 +464,7 @@ public function setRemoteUser($user)
      * daemon. Note that this option is only useful when accessing an rsync daemon
      * using the built in transport, not when using a remote shell as the transport.
      *
-     * @param  string $pass
+     * @param string $pass
      * @return void
      */
     public function setRemotePass($pass)
@@ -476,7 +478,7 @@ public function setRemotePass($pass)
      * rsync is configured to use ssh by default, but you may prefer to use rsh
      * on a local network.
      *
-     * @param  string $shell
+     * @param string $shell
      * @return void
      */
     public function setRemoteShell($shell)
@@ -490,7 +492,7 @@ public function setRemoteShell($shell)
      * information about what files are being transferred and a brief summary at
      * the end.
      *
-     * @param  boolean $verbose
+     * @param boolean $verbose
      * @return void
      */
     public function setVerbose(bool $verbose)
@@ -504,7 +506,7 @@ public function setVerbose(bool $verbose)
      * size and time of last modification match between the sender and receiver.
      * This option changes this to compare a 128-bit checksum for each file that has a matching size.
      *
-     * @param  boolean $checksum
+     * @param boolean $checksum
      * @return void
      */
     public function setChecksum(bool $checksum)
@@ -517,7 +519,7 @@ public function setChecksum(bool $checksum)
      * output as a real run).  It is  most commonly used in combination with the -v, --verbose and/or
      * -i, --itemize-changes options to see what an rsync command is going to do before one actually runs it.
      *
-     * @param  boolean $dryRun
+     * @param boolean $dryRun
      * @return void
      */
     public function setDryRun(bool $dryRun)
@@ -528,7 +530,7 @@ public function setDryRun(bool $dryRun)
     /**
      * Requests a simple itemized list of the changes that are being made to each file, including attribute changes.
      *
-     * @param  boolean $itemizeChanges
+     * @param boolean $itemizeChanges
      * @return void
      */
     public function setItemizeChanges(bool $itemizeChanges)
@@ -541,7 +543,7 @@ public function setItemizeChanges(bool $itemizeChanges)
      * for the directories that are being synchronized. Files that are excluded
      * from transfer are also excluded from being deleted.
      *
-     * @param  boolean $delete
+     * @param boolean $delete
      * @return void
      */
     public function setDelete(bool $delete)
@@ -553,7 +555,7 @@ public function setDelete(bool $delete)
      * Exclude files matching patterns from $file, Blank lines in $file and
      * lines starting with ';' or '#' are ignored.
      *
-     * @param  string $file
+     * @param string $file
      * @return void
      */
     public function setExcludeFile($file)
@@ -564,7 +566,7 @@ public function setExcludeFile($file)
     /**
      * Makes backups into hierarchy based in $dir.
      *
-     * @param  string dir
+     * @param string dir
      * @return void
      */
     public function setBackupDir($dir)
@@ -575,7 +577,7 @@ public function setBackupDir($dir)
     /**
      * Sets the identity file for public key transfers.
      *
-     * @param  string location of ssh identity file
+     * @param string location of ssh identity file
      * @return void
      */
     public function setIdentityFile($identity)
@@ -596,7 +598,7 @@ public function setRemotePort($remotePort)
     /**
      * Sets exclude matching pattern.
      *
-     * @param  string $exclude
+     * @param string $exclude
      * @return void
      */
     public function setExclude($exclude)

diff --git a/classes/phing/tasks/ext/GrowlNotifyTask.php → src/Phing/Task/Optional/GrowlNotifyTask.php b/classes/phing/tasks/ext/GrowlNotifyTask.php → src/Phing/Task/Optional/GrowlNotifyTask.php
@@ -38,6 +38,10 @@
  * @link     https://github.com/llaville/phing-GrowlNotifyTask
  */
 
+namespace Phing\Task\Optional;
+
+use Net_Growl;
+use Net_Growl_Exception;
 use Phing\Exception\BuildException;
 use Phing\Project;
 use Phing\Task;

diff --git a/classes/phing/tasks/ext/JslLintTask.php → src/Phing/Task/Optional/JslLintTask.php b/classes/phing/tasks/ext/JslLintTask.php → src/Phing/Task/Optional/JslLintTask.php
@@ -17,6 +17,8 @@
  * <http://phing.info>.
  */
 
+namespace Phing\Task\Optional;
+
 use Phing\Exception\BuildException;
 use Phing\Io\FileWriter;
 use Phing\Io\File;
@@ -249,9 +251,9 @@ public function main()
      *
      * @param string $file
      *
+     * @return bool|void
      * @throws BuildException
      *
-     * @return bool|void
      */
     protected function lint($file)
     {

diff --git a/classes/phing/tasks/ext/MailTask.php → src/Phing/Task/Optional/MailTask.php b/classes/phing/tasks/ext/MailTask.php → src/Phing/Task/Optional/MailTask.php
@@ -17,6 +17,8 @@
  * <http://phing.info>.
  */
 
+namespace Phing\Task\Optional;
+
 use Phing\Exception\BuildException;
 use Phing\Task;
 use Phing\Type\Element\FileSetAware;

diff --git a/classes/phing/tasks/ext/NotifySendTask.php → src/Phing/Task/Optional/NotifySendTask.php b/classes/phing/tasks/ext/NotifySendTask.php → src/Phing/Task/Optional/NotifySendTask.php
@@ -11,6 +11,8 @@
  * @link     https://github.com/kenguest/Phing-NotifySendTask
  */
 
+namespace Phing\Task\Optional;
+
 use Phing\Exception\BuildException;
 use Phing\Io\FileSystem;
 use Phing\Io\File;
@@ -122,8 +124,8 @@ public function getMsg()
     /**
      * The main entry point method.
      *
-     * @throws BuildException
      * @return void
+     * @throws BuildException
      */
     public function main()
     {

diff --git a/classes/phing/tasks/ext/ParallelTask.php → src/Phing/Task/Optional/ParallelTask.php b/classes/phing/tasks/ext/ParallelTask.php → src/Phing/Task/Optional/ParallelTask.php
@@ -19,6 +19,9 @@
  * @package phing.tasks.ext
  */
 
+namespace Phing\Task\Optional;
+
+use MehrAlsNix;
 use Phing\Exception\BuildException;
 use Phing\Task\System\SequentialTask;