fix: use-cross default false still installing cross #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @grzuy! Thanks for the report! I really don't know if this is related to that, but I find your patch to be better than what is implemented. Thanks! |
philss
pushed a commit
that referenced
this pull request
Oct 27, 2023
|
Thank you! |
|
Indeed this change fixed it for me in mimiquate/candlex#9. First removed the workaround I had, which made build fail.
UPDATE: Saw it got reverted in 1.1.3. |
Merged
|
@grzuy for some reason this version broke my build, as none of the cross installation steps got executed. So I decided to revert in a new version. I'm going to investigate more and try to fix in a future version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @philss , thanks for great work around rustler precompiled!
I was experiencing an issue were not setting
use-crosswould still run the "install cross" step.Could it be because of actions/runner#1173?
I had to
use-cross: nullto make it work right in https://github.com/mimiquate/candlex/pull/9/files#diff-bdfe89ee8491e51e3f81ada685c51d24188416d8b529b443ee6085a0e0fd4a4aR45-R47.Thanks in advance!