Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding missing permissions to boundaries #3873

Merged
merged 2 commits into from
May 17, 2024

Conversation

gnawhleinad
Copy link
Contributor

@gnawhleinad gnawhleinad commented Apr 29, 2024

setup-iam-permissions: add missing iam:TagInstanceProfile required for aws_iam_instance_profile "runner"

The aws_iam_instance_profile resource in

resource "aws_iam_instance_profile" "runner" {
name = "${var.prefix}-runner-profile"
role = aws_iam_role.runner.name
path = local.instance_profile_path
tags = local.tags
}
requires the iam:TagInstanceProfile permission.

@gnawhleinad gnawhleinad force-pushed the bump-iam-permissions branch from 6eece2d to 66f6eb7 Compare April 29, 2024 18:20
@gnawhleinad gnawhleinad changed the title iam:TagInstanceProfile: required for aws_iam_instance_profile "runner" fix setup-iam-permissions: add missing iam:TagInstanceProfile required for aws_iam_instance_profile "runner" Apr 29, 2024
@npalm npalm changed the title fix setup-iam-permissions: add missing iam:TagInstanceProfile required for aws_iam_instance_profile "runner" fix: setup-iam-permissions: add missing iam:TagInstanceProfile required for aws_iam_instance_profile "runner" May 3, 2024
@npalm npalm self-assigned this May 3, 2024
@npalm npalm changed the title fix: setup-iam-permissions: add missing iam:TagInstanceProfile required for aws_iam_instance_profile "runner" fix: adding missing permissions to boundaries May 17, 2024
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@npalm npalm merged commit 93e8d27 into philips-labs:main May 17, 2024
2 of 5 checks passed
npalm pushed a commit that referenced this pull request May 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.11.0](v5.10.4...v5.11.0)
(2024-05-22)


### Features

* add variable to configure ebs optimization for runner instances
([#3901](#3901))
([479b779](479b779))
@AlexShemeshWix
* Restrict instance SSM permissions
([#3918](#3918))
([9399cf2](9399cf2))
@bburky


### Bug Fixes

* adding missing permissions to boundaries
([#3873](#3873))
([93e8d27](93e8d27))
@gnawhleinad
* **lambda:** bump the aws group across 1 directory with 6 updates
([#3907](#3907))
([50dda9a](50dda9a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Co-authored-by: forest-pr|bot <forest-pr[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants