-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add spot termination watcher (beta) #3789
Conversation
@GuptaNavdeep1983 @ScottGuymer @nadavsinai-philips @saragerion Do one of you have any clue why middy is let failing the unit tests. For modules like In
Even without adding the metrics part, which is the only difference comparing to the other modules, the tests are failing. CI is failing as well https://github.com/philips-labs/terraform-aws-github-runner/actions/runs/8129056369/job/22215682414 |
Fixed, figured out the problem. Tracer handler could be undefined in unit test (at least). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a bit of a long one.
tried to take a look at the important stuff and it all seems ok to me.
48c96d5
to
0a0a0f9
Compare
🤖 I have created a release *beep* *boop* --- ## [5.10.0](v5.9.0...v5.10.0) (2024-04-17) ### Features * add spot termination watcher (beta) ([#3789](#3789)) ([b2dc794](b2dc794)) * allow caller to provide custom userdata ([#3798](#3798)) ([ac49daf](ac49daf)) * Allow to disable runner max scaling check ([#3849](#3849)) ([e05a043](e05a043)) ### Bug Fixes * **lambda:** bump axios from 1.6.7 to 1.6.8 in /lambdas ([#3814](#3814)) ([513b22f](513b22f)) * **lambda:** bump the aws group in /lambdas with 5 updates ([#3834](#3834)) ([e7e56ea](e7e56ea)) * **lambda:** bump the aws group in /lambdas with 5 updates ([#3846](#3846)) ([9303a10](9303a10)) * **lambda:** bump the aws group in /lambdas with 6 updates ([#3818](#3818)) ([9a9031e](9a9031e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
This PR is adding a lambda function to watch termination events.
This PR limits to only checking the termination warning. Later we can extend on also start acting on terminations.
Testing
Spot termination can be tested by initiate a termination event via the Spot Request overview (or cli).
Todo