feat(runners): add retry logic to default install and start script for dnf operations #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npalm another one for you. Same logic as the previous pr with retry logic |
|
@npalm @ScottGuymer - need some help here please |
npalm
reviewed
Mar 13, 2024
npalm
approved these changes
Mar 14, 2024
npalm
pushed a commit
that referenced
this pull request
Mar 14, 2024
🤖 I have created a release *beep* *boop* --- ## [5.9.0](v5.8.0...v5.9.0) (2024-03-14) ### Features * **runners:** add retry logic to default install and start script for dnf operations ([#3787](#3787)) ([6a8e1f0](6a8e1f0)) @jkruse14 * Update default runtime from nodejs18.x to nodejs20.x ([#3791](#3791)) ([11ace32](11ace32)) ### Bug Fixes * **lambda:** bump the aws group in /lambdas with 6 updates ([#3803](#3803)) ([eedbf52](eedbf52)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is a continuation of work done in #3748
There seems to be a race condition some where with the user-data script and the EC2 starting up and locking RPM. This issue is seen elsewhere, not necessarily with this repo's user-data, see the following:
Amazon Linux 2023 - issue with installing packages with cloud-init
dnf/yum both fails while being executed on instance bootstrap on Amazon Linux 2023
Also, #3741
Changes Made
Added a loop to retry if the rpm lock file is found which sleeps for 5 seconds then retries again with a total of 5 iterations. This logic is now added to the
user-data.shfor theupgrade-minimaloperation and installation of docker, cloudwatch-agent, and curl.Testing Done
In progress. I'd like to open this up to review while testing.