When wiping last line, don't add newline. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem fixed: Insert a newline at cj>1. Undo (^Z). The undo operation removes cj-1 characters following the point of the insertion.
The fixes a weirdness where wiping the last line is not undone by a single ^Z, due to the newline insertion being a separate event in the undo action list (b.ual). Thus, to get back to the state prior to a wipe of the last line, two undos were required. With this modification, the behavior when wiping the last line is slightly modified. Specifically, the wipe does not include a newline at the end (after all, there was no newline to wipe in the first place). As a consequence, when yanking the wiped line, there we will also be no newline at the end of the insert. For precedence, this is consistent with the emacs ^K on the last line (even if wipe behavior is not in general identical to ^K).
|
Applied. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes a weirdness where wiping the last line is not undone by a
single ^Z, due to the newline insertion being a separate event in the
undo action list (b.ual). Thus, to get back to the state prior to a wipe
of the last line, two undos were required.
With this modification, the behavior when wiping the last line is
slightly modified. Specifically, the wipe does not include a newline at
the end (after all, there was no newline to wipe in the first place). As
a consequence, when yanking the wiped line, there we will also be no
newline at the end of the insert.
For precedence, this is consistent with the emacs ^K on the last line
(even if wipe behavior is not in general identical to ^K).