Skip to content

Commit

Permalink
Use char by char typing in all text fields
Browse files Browse the repository at this point in the history
  • Loading branch information
pheyos committed Dec 4, 2019
1 parent a60b557 commit 2fbccc5
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export function MachineLearningJobSourceSelectionProvider({ getService }: FtrPro
async filterSourceSelection(sourceName: string) {
await testSubjects.setValue('savedObjectFinderSearchInput', sourceName, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertSourceListContainsEntry(sourceName);
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ export function MachineLearningJobWizardAdvancedProvider({
async setDetectorDescription(description: string) {
await testSubjects.setValue('mlAdvancedDetectorDescriptionInput', description, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertDetectorDescriptionValue(description);
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,10 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
},

async setJobId(jobId: string) {
await testSubjects.setValue('mlJobWizardInputJobId', jobId, { clearWithKeyboard: true });
await testSubjects.setValue('mlJobWizardInputJobId', jobId, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertJobIdValue(jobId);
},

Expand All @@ -143,6 +146,7 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
async setJobDescription(jobDescription: string) {
await testSubjects.setValue('mlJobWizardInputJobDescription', jobDescription, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertJobDescriptionValue(jobDescription);
},
Expand Down Expand Up @@ -285,7 +289,10 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
await this.ensureAdvancedSectionOpen();
subj = advancedSectionSelector(subj);
}
await testSubjects.setValue(subj, modelMemoryLimit, { clearWithKeyboard: true });
await testSubjects.setValue(subj, modelMemoryLimit, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertModelMemoryLimitValue(modelMemoryLimit, {
withAdvancedSection: sectionOptions.withAdvancedSection,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export function TransformSourceSelectionProvider({ getService }: FtrProviderCont
async filterSourceSelection(sourceName: string) {
await testSubjects.setValue('savedObjectFinderSearchInput', sourceName, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertSourceListContainsEntry(sourceName);
},
Expand Down
7 changes: 6 additions & 1 deletion x-pack/test/functional/services/transform_ui/wizard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,10 @@ export function TransformWizardProvider({ getService }: FtrProviderContext) {
},

async setTransformId(transformId: string) {
await testSubjects.setValue('transformIdInput', transformId, { clearWithKeyboard: true });
await testSubjects.setValue('transformIdInput', transformId, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertTransformIdValue(transformId);
},

Expand All @@ -322,6 +325,7 @@ export function TransformWizardProvider({ getService }: FtrProviderContext) {
async setTransformDescription(transformDescription: string) {
await testSubjects.setValue('transformDescriptionInput', transformDescription, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertTransformDescriptionValue(transformDescription);
},
Expand All @@ -344,6 +348,7 @@ export function TransformWizardProvider({ getService }: FtrProviderContext) {
async setDestinationIndex(destinationIndex: string) {
await testSubjects.setValue('transformDestinationIndexInput', destinationIndex, {
clearWithKeyboard: true,
typeCharByChar: true,
});
await this.assertDestinationIndexValue(destinationIndex);
},
Expand Down

0 comments on commit 2fbccc5

Please sign in to comment.