You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When a file has diagnostic errors and they all get resolved, the server gives invalid URI (missing file:/ prefix).
To Reproduce
Open any c3 source file
Cause an error (for example remove ;)
Save
Fix the error
Save
Diagnostics with invald URI should be sent from the LSP
Expected behavior
The URI should be correct and error should just disappear.
Screenshots
Desktop (please complete the following information):
OS: NixOS
Editor: neovim
Additional context
I tried fixing this myself, but this required moving the clearOldDiagnostics under the Server struct so I'm not sure if it's the right way to do this (I have pretty much zero experience in Go).
I have my fix in a commit tomaskallup@489f24e, tested it after rebuilding and everything seemed fine.
The fix is tiny, so if it's correct, feel free to just commit it here, I could create a PR, but I would have to cherry-pick it into a fresh branch.
The text was updated successfully, but these errors were encountered:
Describe the bug
When a file has diagnostic errors and they all get resolved, the server gives invalid URI (missing
file:/
prefix).To Reproduce
;
)Expected behavior
The URI should be correct and error should just disappear.
Screenshots
![image](https://private-user-images.githubusercontent.com/26621166/367441951-98b4e577-9733-4efe-8173-4acc838ec822.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzMxOTgsIm5iZiI6MTczOTUzMjg5OCwicGF0aCI6Ii8yNjYyMTE2Ni8zNjc0NDE5NTEtOThiNGU1NzctOTczMy00ZWZlLTgxNzMtNGFjYzgzOGVjODIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDExMzQ1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc3MjI4YjhlNTkwMTMxZjJmNGFiMzI5ZjBlNWQ5NDEyNmRlMjBkZjRhMzg2NjExZGFmMzgxYmFmY2E4ZjUyOGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.uCk8T9rlS4atcogd7DHqG4FNe7Ho5_kUI_PCkB_bh0A)
Desktop (please complete the following information):
Additional context
I tried fixing this myself, but this required moving the
clearOldDiagnostics
under theServer
struct so I'm not sure if it's the right way to do this (I have pretty much zero experience in Go).I have my fix in a commit tomaskallup@489f24e, tested it after rebuilding and everything seemed fine.
The fix is tiny, so if it's correct, feel free to just commit it here, I could create a PR, but I would have to cherry-pick it into a fresh branch.
The text was updated successfully, but these errors were encountered: