Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class com.helger.phive.peppol.PeppolValidation2024_11 has wrong VALID_PER #26

Closed
wildhai opened this issue Jan 17, 2025 · 1 comment
Closed

Class com.helger.phive.peppol.PeppolValidation2024_11 has wrong VALID_PER #26

wildhai opened this issue Jan 17, 2025 · 1 comment
Assignees
@phax
Labels
bug Something isn't working

Comments

@wildhai
Copy link

wildhai commented Jan 17, 2025

The class com.helger.phive.peppol.PeppolValidation2024_11 of phive-rules-peppol-3.2.4 has wrong VALID_PER value:

"... public static final LocalDate VALID_PER = PDTFactory.createLocalDate (2024, Month.FEBRUARY, 17); ..."

This means 2024-02-17 in year 2024 but needs to be 2025-02-17 in year 2025.
@phax phax self-assigned this Jan 17, 2025
@phax phax added bug Something isn't working format update Support a new version of a format and removed format update Support a new version of a format labels Jan 17, 2025
phax added a commit that referenced this issue Jan 17, 2025
@phax
Fixed valid per date; #26
842de54
@phax
Copy link
Owner

phax commented Jan 17, 2025

@wildhai Thanks for bringing that to my attention. Will be fixed in the next release. I don't build a release asap but wait for other updates. I will however create a bugfix release in January.

@phax phax closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @wildhai