Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imagick::getVersion() to Imagick->getVersion() [ci skip] #12729

Merged
merged 6 commits into from
Mar 30, 2017
Merged

Imagick::getVersion() to Imagick->getVersion() [ci skip] #12729

merged 6 commits into from
Mar 30, 2017

Conversation

youyoubao
Copy link
Contributor

@youyoubao youyoubao commented Mar 21, 2017 •
edited
Loading

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:
In some systems, the extend Imagick can't call method Imagick::getVersion(), but can be call as Imagick->getVersion()

Thanks

sergeyklay and others added 2 commits March 21, 2017 02:22
@sergeyklay
Merge pull request phalcon#12727 from sergeyklay/3.1.x
9f52075 
Regenerated build
@youyoubao
Update imagick.zep
46eed06 
Imagick none-static method getVersion
@youyoubao youyoubao changed the title Imagick::getVersion() to Imagick->getVersion() Imagick::getVersion() to Imagick->getVersion() [ci skip] Mar 21, 2017
@sergeyklay sergeyklay closed this Mar 21, 2017
@sergeyklay sergeyklay reopened this Mar 21, 2017
@sergeyklay sergeyklay force-pushed the 3.1.x branch 2 times, most recently from f115731 to c7de98d Compare March 21, 2017 23:32
@sergeyklay
Copy link
Contributor

@dormscript Could you please update CHANGELOG.md

@youyoubao
Copy link
Contributor Author

@sergeyklay changelog has commited

@sergeyklay sergeyklay merged commit 4a410d7 into phalcon:3.1.x Mar 30, 2017
@sergeyklay
Copy link
Contributor

Thank you

sergeyklay pushed a commit that referenced this pull request Apr 2, 2017
@youyoubao @sergeyklay
Fixed call Imagick::getVersion() (#12729)
631213a 
* Update imagick.zep

Imagick none-static method getVersion

* update CHANGELOG.md

* Update CHANGELOG.md [ci skip]
@youyoubao youyoubao deleted the 3.1.x branch April 7, 2017 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youyoubao @sergeyklay