Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up pgr_ksp pgr_withPointsKSP #2572

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Clean up pgr_ksp pgr_withPointsKSP #2572

merged 4 commits into from
Oct 2, 2023

Conversation

cvvergara
Copy link
Member

Changes proposed in this pull request:

  • clean up pgr_ksp
    • removed one driver function
    • removed one static function
    • renamed internal function without v4 suffix
  • clean up pgr_withPointsKSP
    • removed one static function
    • renamed internal function without v4 suffix

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.6.0 milestone Sep 30, 2023
@cvvergara cvvergara marked this pull request as ready for review September 30, 2023 22:51
@Aniket-debug
Copy link
Contributor

looks good to me

@cvvergara cvvergara merged commit b9c3950 into pgRouting:develop Oct 2, 2023
@cvvergara cvvergara deleted the cleanup-ksp-withPointsKSP branch October 2, 2023 16:45
omshinde
omshinde reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@omshinde omshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omshinde omshinde omshinde left review comments

@Aniket-debug Aniket-debug Aniket-debug approved these changes

@robe2 robe2 robe2 approved these changes

@dkastl dkastl Awaiting requested review from dkastl

@cayetanobv cayetanobv Awaiting requested review from cayetanobv

@AbhinJ AbhinJ Awaiting requested review from AbhinJ

Assignees
No one assigned
Labels
C/C++ Enhancement
Projects
None yet
Milestone
Release 3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cvvergara @Aniket-debug @robe2 @omshinde