-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC 2023] Modifying drivingdistance #2548
Conversation
Please also update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay aside from the missing news that @krashish8 mentioned.
@robe2 @krashish8 i have updated news and release_notes |
You don't have to update NEWS manually. Use this script to generate NEWS: Also, the release_notes.rst file is not formatted correctly. The links are written in a different way in an rst file (you can refer how other students did). NEWS will resemble markdown format. |
9d5c21d
to
769d1b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links are written in a different format in rst file: https://sublime-and-sphinx-guide.readthedocs.io/en/latest/references.html#links-to-external-web-pages
I think @Aniket-debug also needs to fix this in the release notes.
Otherwise, this looks good. 🎉
I think @squarege made this mistake too. I'll go ahead and merge this for expediency. |
This PR modifies one existing function:
This is a final merge PR containing commits from several different PRs combined.
The intermediate PRs made on the GSoC-pgRouting repository are as follows:
The wiki page with more details on this project can be found here.