Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflow #57

Merged
merged 43 commits into from
Oct 13, 2022
Merged

Add release workflow #57

merged 43 commits into from
Oct 13, 2022

Conversation

mist714
Copy link
Contributor

@mist714 mist714 commented Oct 12, 2022

Launch the release workflow when a tag is assigned.
Use goreleaser.

@mist714 mist714 requested a review from everpeace October 12, 2022 08:32
Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update Makefile and README(documenting for release procedure), too??

@mist714 mist714 requested a review from everpeace October 12, 2022 09:02
Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. PTAL 🙇

Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM overall. small comments only.

mist714 and others added 2 commits October 13, 2022 06:54
Co-authored-by: Shingo Omura <everpeace@gmail.com>
@mist714 mist714 requested a review from everpeace October 12, 2022 21:57
Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for my repeated change requests 🙇

  • Dockerfile is not used now. let's delete it.
  • In the next release, the released image name will be ghcr.io/pfnet-research/git-ghost. So, could you look at example/ and fix inconsistency mainly about the image name?? Perhaps, we won't need the templates about container image part, we can use latest image.

@mist714 mist714 requested a review from everpeace October 13, 2022 02:05
Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost finished. please fix image name here and typo commented.

mist714 and others added 2 commits October 13, 2022 11:18
Co-authored-by: Shingo Omura <everpeace@gmail.com>
@mist714 mist714 requested a review from everpeace October 13, 2022 02:21
Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! finally! Thank you very much!

@mist714 mist714 merged commit f4e32c9 into master Oct 13, 2022
@mist714 mist714 deleted the release-flow branch October 13, 2022 02:25
This was referenced Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants