-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update Makefile and README(documenting for release procedure), too??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. PTAL 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM overall. small comments only.
Co-authored-by: Shingo Omura <everpeace@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for my repeated change requests 🙇
Dockerfile
is not used now. let's delete it.- In the next release, the released image name will be
ghcr.io/pfnet-research/git-ghost
. So, could you look atexample/
and fix inconsistency mainly about the image name?? Perhaps, we won't need the templates about container image part, we can use latest image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost finished. please fix image name here and typo commented.
Co-authored-by: Shingo Omura <everpeace@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! finally! Thank you very much!
Launch the release workflow when a tag is assigned.
Use goreleaser.