Fix handling of --cert and --client-cert.
#1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to work around pypa/pip#5502 fully, we extract a `PackageIndexConfiguration` class that handles arrangement of Pip command line flags and enviornment variables to effect the most hermetic means possible of conveying `--cert` and `--client-cert` to Pip and its subprocesses. Fixes pex-tool#1058
|
@thamenato this should finally do it. |
jsirois
commented
Oct 8, 2020
|
|
||
| class PackageIndexConfiguration(object): | ||
| @staticmethod | ||
| def _calculate_args( |
There was a problem hiding this comment.
This method was moved from https://github.com/pantsbuild/pex/pull/1063/files#diff-77bac56887c1a03806e247fe60c2024cL129 but otherwise unchanged save for the top comment.
|
What a journey! Hopefully this is the end of it. |
benjyw
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work around pypa/pip#5502 fully,
we extract a
PackageIndexConfigurationclass that handles arrangementof Pip command line flags and enviornment variables to effect the most
hermetic means possible of conveying
--certand--client-certto Pipand its subprocesses.
Fixes #1058