Skip to content

Commit

Permalink
Change criterion for diverging efficiency
Browse files Browse the repository at this point in the history
For the first iteration to find the discharge state we assume an
isentropic compression and in the initial steps it is possible that we
get efficiencies higher than 1.
We are now setting the ceiling to 1.5, but we should evaluate if for
some cases (e.g. first section of back to back compressors) it is not
reasonable to get higher efficiencies.
  • Loading branch information
raphaeltimbo committed Dec 11, 2024
1 parent 0237cf6 commit 94a2b95
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ccp/point.py
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,8 @@ def update_state(x, update_type):
elif update_type == "temperature":
disch.update(rho=disch_rho, T=x)
new_eff = self.eff_calc_func(self.suc, disch)
if not 0.0 < new_eff < 1.1:
raise ValueError
if not 0.0 < new_eff < 1.5:
raise ValueError("Efficiency did not converge")

return (new_eff - eff).magnitude

Expand Down

0 comments on commit 94a2b95

Please sign in to comment.