Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update action runtime to node 16 #1074

Merged
merged 6 commits into from
Feb 28, 2022
Merged

Update action runtime to node 16 #1074

merged 6 commits into from
Feb 28, 2022

Conversation

sibiraj-s
Copy link
Contributor

  • update action runtime to node 16
  • use getBooleanInput and getMultilineInput from actions/code

peter-evans
peter-evans requested changes Feb 28, 2022
View reviewed changes
Copy link
Owner

@peter-evans peter-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sibiraj-s

Thank you for contributing.
Please see my comment about reverting getMultilineInput, but the other changes look good to me.

src/main.ts Outdated Show resolved Hide resolved
src/main.ts Show resolved Hide resolved
@peter-evans
Copy link
Owner

peter-evans commented Feb 28, 2022 •
edited by actions-bot
Loading

/test repository=sibiraj-s/create-pull-request ref=node-16 build=true

Command run output

@peter-evans peter-evans merged commit 89265e8 into peter-evans:main Feb 28, 2022
@peter-evans
Copy link
Owner

Thank you!

@sibiraj-s sibiraj-s deleted the node-16 branch February 28, 2022 06:16
@sibiraj-s sibiraj-s restored the node-16 branch February 28, 2022 06:16
@sibiraj-s sibiraj-s deleted the node-16 branch February 28, 2022 06:16
@peter-evans
Copy link
Owner

Unfortunately, I had to revert this commit because it caused an issue for users on GitHub Enterprise.

@sibiraj-s
Copy link
Contributor Author

Apologies. I had no idea that Github Enterprise didn't support it. It was quite a while since node16 was released, and I failed to account enterprise runners.

@peter-evans
Copy link
Owner

No worries. It was my bad for not checking. Appreciate the effort to contribute. 👍

@sibiraj-s
Copy link
Contributor Author

Thanks.

And, node 12 is coming to its EOL next month. And many official actions started releasing new majors for node 16. Any thoughts on v4?

@peter-evans
Copy link
Owner

Yep, I noticed the same and commented here: #1077 (comment)
I'll probably release a v4 at some point in the next month or so.

@sibiraj-s
Copy link
Contributor Author

Awesome 🚀

0xMRTT added a commit to GradienceTeam/Gradience that referenced this pull request Aug 19, 2022
@0xMRTT
build(deps): bump peter-evans/create-pull-request from 3 to 4 (#186)
5e391ae 
Bumps peter-evans/create-pull-request from 3 to 4.

Release notes
Sourced from peter-evans/create-pull-request's releases.

Create Pull Request v4.0.0
Breaking changes

The add-paths input no longer accepts -A as a valid value. When committing all new and modified files the add-paths input should be omitted.
If using self-hosted runners or GitHub Enterprise Server, there are minimum requirements for v4 to run. See "What's new" below for details.

What's new

Updated runtime to Node.js 16

The action now requires a minimum version of v2.285.0 for the Actions Runner.
If using GitHub Enterprise Server, the action requires GHES 3.4 or later.



What's Changed

README.md: Add word "permissions" to part on GITHUB_TOKEN by @​hartwork in peter-evans/create-pull-request#1082
docs: Document how to improve close-and-reopen user experience by @​hartwork in peter-evans/create-pull-request#1084
README.md: Skip follow-up steps if there is no pull request by @​hartwork in peter-evans/create-pull-request#1083
v4 by @​peter-evans in peter-evans/create-pull-request#1099

New Contributors

@​hartwork made their first contribution in peter-evans/create-pull-request#1082

Full Changelog: peter-evans/create-pull-request@v3.14.0...v4.0.0
Create Pull Request v3.14.0
This release reverts a commit made to bump the runtime to node 16. It inadvertently caused an issue for users on GitHub Enterprise. Apologies. 🙇‍♂️
What's Changed

feat: revert update action runtime to node 16 by @​peter-evans peter-evans/create-pull-request@18f7dc0

Full Changelog: peter-evans/create-pull-request@v3.13.0...v3.14.0
Create Pull Request v3.13.0
What's Changed

Document that draft status changes are not reflected by @​willthames in peter-evans/create-pull-request#1064
fix: remove unused draft param from pull update by @​peter-evans in peter-evans/create-pull-request#1065
Update action runtime to node 16 by @​sibiraj-s in peter-evans/create-pull-request#1074

New Contributors

@​willthames made their first contribution in peter-evans/create-pull-request#1064
@​sibiraj-s made their first contribution in peter-evans/create-pull-request#1074

Full Changelog: peter-evans/create-pull-request@v3.12.1...v3.13.0
Create Pull Request v3.12.1
What's Changed

ci: remove workflow by @​peter-evans in peter-evans/create-pull-request#1046
fix: add '--' to checkout command to avoid ambiguity by @​kenji-miyake in peter-evans/create-pull-request#1051

New Contributors

@​kenji-miyake made their first contribution in peter-evans/create-pull-request#1051



... (truncated)


Commits

18f9043 build: update distribution (#1216)
2721abb fix: handle nothing to commit when autocrlf is set (#1211)
20dac2e build: update distribution (#1208)
8557470 feat: support no_proxy environment variable (#1205)
10db758 docs: add info about workflow permissions
5a6b153 docs: clearer description of update behaviour
923ad83 force tryFetch (#1189)
f094b77 fix: avoid issue with case sensitivity of repo names (#1179)
af7c021 docs: shorten quote
97872c4 docs: update GA quote/ref in concepts-guidelines.md (#1169)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@ericcornelissen ericcornelissen mentioned this pull request Sep 12, 2023
Merged
aleksandrychev pushed a commit to aleksandrychev/create-pull-request that referenced this pull request Mar 4, 2024
@sibiraj-s @aleksandrychev
feat: update action runtime to node 16 (peter-evans#1074)
e0382e9 
* fix: prefer getMultilineInput and getBooleanInput from actions/core

* build: update distribution

* feat: update action runtime to node 16

* ci: update setup-node and cache npm dependencies

* revert: getMultilineInput to getInputAsArray

* build: update distribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-evans peter-evans peter-evans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sibiraj-s @peter-evans