Initial probe configuration #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Mar 19, 2019
| @@ -44,14 +45,22 @@ public sealed class AkkaHealthCheck : IExtension | |||
| public AkkaHealthCheck(HealthCheckSettings settings, ExtendedActorSystem system) | |||
| { | |||
| Settings = settings; | |||
| system.Log.Info("Liveness Prove Provider: {0}", Settings.LivenessProbeProvider); | |||
There was a problem hiding this comment.
Looks good, but need to add that log-info setting here and check to see if that's on before logging all of these
Aaronontheweb
approved these changes
Mar 19, 2019
|
|
||
| var settings = new HealthCheckSettings(hocon.WithFallback(HealthCheckSettings.DefaultConfig()) | ||
| .GetConfig("akka.healthcheck")); | ||
| settings.LogConfigOnStart.Should().BeFalse(); |
izavala
added a commit
that referenced
this pull request
Mar 20, 2019
* Initial probe configuration * Removed test string * Parsed log-config-on-start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.