Skip to content

Commit

Permalink
fix naming collisions with new interfaces (#34)
Browse files Browse the repository at this point in the history
  • Loading branch information
Aaronontheweb authored Jan 7, 2020
1 parent 348934f commit 4a8b02e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
At present, this repository exposes the following interfaces for use within [Akka.NET](http://getakka.net/) applications that intend to leverage Phobos in production:

* [`INeverTrace`](https://phobos.petabridge.com/api/Phobos.Actor.Common.INeverTrace.html) - permanently disables tracing support for any actors marked with this interface and cannot be overridden by configuration.
* [`ITrace`](https://phobos.petabridge.com/api/Phobos.Actor.Common.ITrace.html) - explicitly adds tracing support to a message, actor, etc.
* [`IWithTrace`](https://phobos.petabridge.com/api/Phobos.Actor.Common.IWithTrace.html) - explicitly adds tracing support to a message, actor, etc.
* [`INeverMonitor`](https://phobos.petabridge.com/api/Phobos.Actor.Common.INeverMonitor.html) - permanently disables monitoring support for any actors marked with this interface and cannot be overridden by configuration.
* [`IMonitor`](https://phobos.petabridge.com/api/Phobos.Actor.Common.IMonitor.html) - explicitly adds monitoring support to a message, actor, etc.
* [`IWithMonitor`](https://phobos.petabridge.com/api/Phobos.Actor.Common.IWithMonitor.html) - explicitly adds monitoring support to a message, actor, etc.

And then we have some aggregate interfaces for simplification purposes:

Expand Down
2 changes: 1 addition & 1 deletion src/Phobos.Actor.Common/IInstrumented.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Phobos.Actor.Common
/// <summary>
/// Marker interface that indicates that this resource is fully instrumented.
/// </summary>
public interface IInstrumented : ITrace, IMonitor
public interface IInstrumented : IWithTrace, IWithMetrics
{
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Phobos.Actor.Common
/// <summary>
/// Marker interface used to indicate that this actor, message, etc always records metric events.
/// </summary>
public interface IMonitor
public interface IWithMetrics
{
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Phobos.Actor.Common
/// Marker interface that indicates that this actor, message, etc is used
/// by Phobos to begin traces.
/// </summary>
public interface ITrace
public interface IWithTrace
{
}
}

0 comments on commit 4a8b02e

Please sign in to comment.