Deprecate robot/util -> planToConfiguration() [WIP] #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
planToConfiguration()
fromrobot/util
, and updates the corresponding function inConcreteRobot
to use a snap planner.We actually don't remove the method completely from
robot/util
, just the header: it's needed elsewhere in the.cpp
file.TODO/WIP:
ConfigurationToConfiguration
planner, or the DART version? Both work fine here and the normal version requires less cruft, so I've gone with that. LMK your thoughts!ConcreteRobot -> planToConfiguration
, or have a planner member var inConcreteRobot
? The reason I didn't do this is because theMetaSkeleton
passed to the planner constructor(s) may not match themetaSkeleton
argument ofplanToConfiguration()
.Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md