Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate robot/util -> planToConfiguration() [WIP] #586

Closed
wants to merge 1 commit into from

Conversation

sniyaz
Copy link

@sniyaz sniyaz commented Sep 26, 2020

This PR removes planToConfiguration() from robot/util, and updates the corresponding function in ConcreteRobot to use a snap planner.

We actually don't remove the method completely from robot/util, just the header: it's needed elsewhere in the .cpp file.

TODO/WIP:

  1. Should we use the normal ConfigurationToConfiguration planner, or the DART version? Both work fine here and the normal version requires less cruft, so I've gone with that. LMK your thoughts!
  2. Should we construct the planner in ConcreteRobot -> planToConfiguration, or have a planner member var in ConcreteRobot? The reason I didn't do this is because the MetaSkeleton passed to the planner constructor(s) may not match the metaSkeleton argument of planToConfiguration().

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@sniyaz sniyaz requested review from brianhou and egordon and removed request for gilwoolee September 26, 2020 03:30
@brianhou
Copy link
Contributor

brianhou commented Oct 6, 2020

Should this be closed in favor of #588?

@sniyaz sniyaz closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants