-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix convertShape to use getMeshPath #518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The suggestions from @brianhou sound good to me as well.
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 75.59% 75.59%
=======================================
Files 243 243
Lines 5856 5856
=======================================
Hits 4427 4427
Misses 1429 1429 |
Co-Authored-By: gilwoolee <gilwoo301@gmail.com>
This PR fixes
rviz::convertShape(MeshShape...)
method to usegetMeshPath
instead ofgetMeshUri
formeshUri
.When a mesh is loaded via MeshShape,
convertShape(MeshShape...)
gets called. SincemeshUri
is used by Rviz, it has to be a raw filepath, which is not the case when usinggetMeshUri
.This was never an issue with Herb or Ada because we use
urdfLoader
and it constructs AssimpMesh, which doesn't call this function. It was discovered while @vinitha910 was trying to load cozmo mesh directly using raw filepaths.It has been tested by constructing cozmo with MeshShapes and visualizing it in Rviz through aikido InteractiveViewer.
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md