Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rviz dependencies. #253

Merged
merged 5 commits into from
Nov 2, 2017
Merged

Add rviz dependencies. #253

merged 5 commits into from
Nov 2, 2017

Conversation

brianhou
Copy link
Contributor

@brianhou brianhou commented Nov 2, 2017 •
edited
Loading

I was having trouble compiling dart_examples while working on personalrobotics/dart_examples#8. This seemed to fix it.

  • constraint is used because we visualize TSRs
  • planner is used because we visualize Worlds

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@brianhou brianhou added this to the Aikido 0.2.0 milestone Nov 2, 2017
@brianhou brianhou requested a review from jslee02 November 2, 2017 05:17
jslee02
jslee02 reviewed Nov 2, 2017
View reviewed changes
Copy link
Member

@jslee02 jslee02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the component dependencies as well like this?

It's loosely maintained, but it would be grateful if you update this line as well. 😅

@codecov
Copy link

codecov bot commented Nov 2, 2017 •
edited
Loading

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   70.43%   70.43%           
=======================================
  Files         181      181           
  Lines        5391     5391           
  Branches      847      847           
=======================================
  Hits         3797     3797           
  Misses       1074     1074           
  Partials      520      520

jslee02
jslee02 approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@brianhou brianhou merged commit fbbb366 into master Nov 2, 2017
@brianhou brianhou deleted the bugfix/brianhou/cmake branch November 2, 2017 16:53
gilwoolee pushed a commit that referenced this pull request Jan 21, 2019
@brianhou
Add rviz dependencies. (#253)
cf3c4a7 
* Add rviz dependencies.

* Remove implicit dependency.

* Address Jeongseok's comments.

* Reorganize add_subdirectory calls.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslee02 jslee02 jslee02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aikido 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhou @jslee02