Skip to content

Commit

Permalink
Revert "Fix issues discovered during demo. (#442)"
Browse files Browse the repository at this point in the history
This reverts commit f05e40b.
  • Loading branch information
Ponzel committed Jul 17, 2018
1 parent 13e98b4 commit b459174
Show file tree
Hide file tree
Showing 35 changed files with 114 additions and 761 deletions.
4 changes: 2 additions & 2 deletions include/aikido/planner/ConfigurationToConfiguration.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ class ConfigurationToConfiguration : public Problem

protected:
/// Start state.
statespace::StateSpace::ScopedState mStartState;
const statespace::StateSpace::State* mStartState;

/// Goal state.
statespace::StateSpace::ScopedState mGoalState;
const statespace::StateSpace::State* mGoalState;
};

} // namespace planner
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ class ConfigurationToConfigurationPlanner
// which is simply ConfigurationToConfiguration.
using SingleProblemPlanner::plan;

/// \copydoc Planner::Planner
/// Constructor
///
/// \param[in] stateSpace State space that this planner associated with.
explicit ConfigurationToConfigurationPlanner(
statespace::ConstStateSpacePtr stateSpace, common::RNG* rng = nullptr);
statespace::ConstStateSpacePtr stateSpace);

/// Solves \c problem returning the result to \c result.
///
Expand Down
10 changes: 1 addition & 9 deletions include/aikido/planner/Planner.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,14 @@ class Planner
/// Constructs from a state space.
///
/// \param[in] stateSpace State space that this planner associated with.
/// \param[in] rng RNG that planner uses. If nullptr, a default is created.
explicit Planner(
statespace::ConstStateSpacePtr stateSpace, common::RNG* rng = nullptr);
explicit Planner(statespace::ConstStateSpacePtr stateSpace);

/// Default destructor.
virtual ~Planner() = default;

/// Returns const state space.
statespace::ConstStateSpacePtr getStateSpace() const;

/// Returns RNG.
common::RNG* getRng();

/// Returns true if this planner can solve \c problem.
virtual bool canSolve(const Problem& problem) const = 0;

Expand All @@ -49,9 +44,6 @@ class Planner
protected:
/// State space associated with this planner.
statespace::ConstStateSpacePtr mStateSpace;

/// RNG the planner uses.
std::unique_ptr<common::RNG> mRng;
};

/// Base class for planning result of various planning problems.
Expand Down
7 changes: 4 additions & 3 deletions include/aikido/planner/SingleProblemPlanner.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ class SingleProblemPlanner : public Planner
public:
using SolvableProblem = ProblemT;

/// \copydoc Planner::Planner
explicit SingleProblemPlanner(
statespace::ConstStateSpacePtr stateSpace, common::RNG* rng = nullptr);
/// Constructor
///
/// \param[in] stateSpace State space associated with this planner.
explicit SingleProblemPlanner(statespace::ConstStateSpacePtr stateSpace);

// Documentation inherited.
bool canSolve(const Problem& problem) const final override;
Expand Down
75 changes: 0 additions & 75 deletions include/aikido/planner/dart/ConfigurationToConfiguration.hpp

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,15 @@ namespace aikido {
namespace planner {
namespace dart {

/// Converts a non-DART ConfigurationToConfiguration planner into a DART
/// ConfigurationToTSR planner.
class ConfigurationToConfiguration_to_ConfigurationToTSR
: public PlannerAdapter<aikido::planner::
ConfigurationToConfigurationPlanner,
: public PlannerAdapter<ConfigurationToConfigurationPlanner,
ConfigurationToTSRPlanner>
{
public:
/// Constructor
///
/// \param[in] planner Non-DART ConfigurationToConfigurationPlanner planner to
/// convert.
/// \param[in] metaSkeleton MetaSkeleton for adapted planner to operate on.
ConfigurationToConfiguration_to_ConfigurationToTSR(
std::shared_ptr<aikido::planner::ConfigurationToConfigurationPlanner>
planner,
std::shared_ptr<ConfigurationToConfigurationPlanner> planner,
::dart::dynamics::MetaSkeletonPtr metaSkeleton);

// Documentation inherited.
virtual trajectory::TrajectoryPtr plan(
const ConfigurationToTSR& problem, Planner::Result* result) override;
};
Expand Down
Loading

0 comments on commit b459174

Please sign in to comment.