Add response to the WebDAVClientError type #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d25d24 to
124ba8b
Compare
perry-mitchell
requested changes
May 17, 2021
source/response.ts
Outdated
| @@ -7,6 +8,7 @@ export function handleResponseCode(context: WebDAVClientContext, response: Respo | |||
| if (status >= 400) { | |||
| const err: WebDAVClientError = new Error(`Invalid response: ${status} ${response.statusText}`) as WebDAVClientError; | |||
| err.status = status; | |||
| err.response = response as AxiosResponse; | |||
There was a problem hiding this comment.
I'd prefer not to expose Axios-specific properties outside of this library, as I can't guarantee that I'll always use Axios as the request client. Would you consider changing this to err.response = response (only) and using the Response type in the WebDAVClientError interface?
|
@perry-mitchell I've fixed it. Please have a look. |
perry-mitchell
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add response property to WebDAVClientError type.
the error handleing is no longer handled by axios (https://github.com/perry-mitchell/webdav-client/blob/master/source/request.ts#L52) so the error object doesn't has access to the HTTP response. this PR fixes that.