Allow setting the option maxBodyLength
on putFileContents()
#220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I recently ran into a problem when uploading big files to a nextcloud instance. Axios would complain
This PR allows using the option
maxBodyLength
directly on theputFileContents
method of this webdav client. One would use it for example like this:To achieve this, the option is simply passed through to axios which in turn will pass it on to
follow-redirects
, which is it's default backend in nodejs environments. It did in fact solve the issue in my project.Until earlier this year, axios would have used the value of
maxContentLength
to set the value ofmaxBodyLength
, but at some point someone found out that those two are in fact not the same and changed that behaviour, which I assume broke functionality ofwebdav-client
as well. In my understanding,maxContentLength
is now supposed to be used only for setting the limit of the respnse size, whilemaxBodyLength
defines the limit of the request body size. See this issue for reference: axios/axios#2696Let me know what you think!
Best,
Benjamin.