provide callback for writeStream #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-bar Thanks! I made some changes to improve the callback handling, as the response handler still needs to be fired. |
perry-mitchell
approved these changes
Mar 31, 2020
|
@perry-mitchell Thanks so much for your improvement. This is my first merge request on Github so I'm really glad you liked it! |
|
Good work @h-bar - appreciate the MR. Please drop by again if you have more suggestions :) - This is now live in 3.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no way to see if the request sent by writeStream (for uploading a file) is finished or not. The writeStream.on("finish") event is fired before the request is complement since the request itself is synchronize. This change adds a callback option when creating writeStream so that the callback is executed when the request sent by the writeStream is finished sending data