Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new gerps ID #4670

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Create new gerps ID #4670

merged 3 commits into from
Jan 23, 2025

Conversation

BMI24
Copy link
Contributor

@BMI24 BMI24 commented Jan 22, 2025

We decided to deprecate the GerPS-onto PURLs (multiple reasons, they were created without regards to our self-defined conventions) and instead use the lower-case gerps PURL

@BMI24
Copy link
Contributor Author

BMI24 commented Jan 22, 2025

If I need to squash the merge commit with the actual change, please ping me

# Rewrite engine setup
RewriteEngine On

RedirectMatch 301 ^/gerps/ontology/?$ https://fusion-jena.github.io/gerps-onto-landingpage/#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want this, since you would be going to /gerps/ontology/gerps/ontology
In this case, it would suffice to do ^$

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably ok since it's RedirectMatch. Consider aligning with the rest of these files and use RewriteRule with ^$ instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced it with RewriteRule, thanks! (but yeah, I tested it locally beforehand)

# Turn off MultiViews
Options -MultiViews

Redirect 301 /GerPS-onto /gerps/ontology/process
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would go to the same id twice: w3id.org/GerPS-onto//GerPS-onto. Please review

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok since it's Redirect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally beforehand and it works as expected. If you'd like for me to use a different command, please tell me which

@dgarijo
Copy link
Collaborator

dgarijo commented Jan 22, 2025

@BMI24 please have a look at the comments

@davidlehn davidlehn merged commit 64fe35d into perma-id:master Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants