Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatability with wasmtime 0.19.0 #77

Merged
merged 2 commits into from
Jul 18, 2020
Merged

compatability with wasmtime 0.19.0 #77

merged 2 commits into from
Jul 18, 2020

Conversation

plicease
Copy link
Member

This attempts to add comparability to 0.19.0 without breaking the Perl level API. (alternative to #76)

@plicease
Copy link
Member Author

I think this is the way to go, if we detect if we are using 0.19.0, and only apply this change at runtime for that version. Unfortunately, Wasmtime doesn't have an interface for determining the version

bytecodealliance/wasmtime#986

so we will have to do it by probing for unrelated symbols that only exist in 0.19.0, which is a little icky.

Down the line, we can break the Perl level API if it makes sense to do so, but we should wait until 0.19.0 has time to percolate through cpantesters etc.

@plicease plicease merged commit 6bc6bd1 into main Jul 18, 2020
@plicease plicease deleted the graham/bump-19-2 branch July 18, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant