Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize saving memory of contract snapshot. #202

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Optimize saving memory of contract snapshot. #202

merged 1 commit into from
Sep 2, 2019

Conversation

a-urth
Copy link
Contributor

@a-urth a-urth commented Sep 2, 2019

Bytes comparison in plain loop was inefficient and redundant.

@a-urth a-urth self-assigned this Sep 2, 2019
iwasaki-kenta
iwasaki-kenta approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@iwasaki-kenta iwasaki-kenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iwasaki-kenta iwasaki-kenta added the enhancement New feature or request label Sep 2, 2019
@iwasaki-kenta iwasaki-kenta merged commit d5f5990 into master Sep 2, 2019
@iwasaki-kenta iwasaki-kenta deleted the smart-contract-optimization branch September 2, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwasaki-kenta iwasaki-kenta iwasaki-kenta approved these changes

@rkeene rkeene Awaiting requested review from rkeene

Assignees

@a-urth a-urth

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-urth @iwasaki-kenta