(consoleapp) Fix exception in mintty-based shells on Windows #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
commented
Feb 15, 2022
| @@ -201,7 +205,7 @@ public static int MainWithCustomConsole(string[] args, IConsole console) | |||
| replMode: true, | |||
| standardOutputHandler: console.Out.WriteLine, | |||
| disabledWarningsAsErrors: disabledWarningsAsErrorsList | |||
| ).RunPrompt(); | |||
| ).RunPrompt(args); | |||
There was a problem hiding this comment.
(args is typically empty in these cases, but it doesn't hurt to provide it to future-proof in case it will be non-empty sometime in the future.)
9be825b to
dcb40e5
Compare
dcb40e5 to
9985fbf
Compare
perlun
added a commit
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had thought about this for some day(s), and decided to give it a look. The fact that
winptyexists surely makes this a whole lot easier to "fix", even though it's a bit of a workaround. It does make Perlang much more accessible for people who are locked inside their Windows, so that makes this a noteworthy fix. 😛Closes #107