fix string comparisons with $] to use numeric comparison instead #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23e1e60 to
d01de45
Compare
lib/Pod/Simple/RTF.pm
Outdated
| @@ -551,7 +551,7 @@ my $other_unicode = | |||
| Pod::Simple::BlackBox::my_qr('([\x{10000}-\x{10FFFF}])', "\x{10000}"); | |||
|
|
|||
| sub esc_uni($) { | |||
| use if $] le 5.006002, 'utf8'; | |||
| use if do { no integer; "$]" >= 5.006002 }, 'utf8'; | |||
There was a problem hiding this comment.
This is not equivalent to the previous line, but I think what you have here now is correct, as surely one does not mean to use utf8 on a version where it does not exist! :)
There was a problem hiding this comment.
Oh wow, that's a bug I introduced myself! This >= should indeed be a <=. Will push a fixed commit.
Thanks for catching this!
The fix follows Zefram's suggestion from https://www.nntp.perl.org/group/perl.perl5.porters/2012/05/msg186846.html > On older perls, however, $] had a numeric value that was built up using > floating-point arithmetic, such as 5+0.006+0.000002. This would not > necessarily match the conversion of the complete value from string form > [perl #72210]. You can work around that by explicitly stringifying > $] (which produces a correct string) and having *that* numify (to a > correctly-converted floating point value) for comparison. I cultivate > the habit of always stringifying $] to work around this, regardless of > the threshold where the bug was fixed. So I'd write > > use if "$]" >= 5.014, warnings => "non_unicode"; Note that, because some of the files do a `use integer`, the numeric comparisons with $] a `no integer` needs to be done in a lexical scope around the comparison, to avoid truncation to integers, which spoils the comparisons. Hence the ugly `do { no integer ; ... }` in some places.
d01de45 to
a24d9e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix follows Zefram's suggestion from
https://www.nntp.perl.org/group/perl.perl5.porters/2012/05/msg186846.html
Note that, because some of the files do a
use integer, the numericcomparisons with $] a
no integerneeds to be done in a lexical scopearound the comparison, to avoid truncation to integers, which spoils
the comparisons. Hence the ugly
do { no integer ; ... }in some places.