When Pod-Simple is in PERL_CORE we can build with a readonly source directory #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Cwd::abs_path resolves symlinks, it means if we are in PERL_CORE and building perl outside of the source directory, whle the main source directory is readonly, some of the tests fail because they can't write to the source directory when they should be writing to the build directory, or ideally to a tmpdir. https://github.com/Perl/perl5/blob/blead/INSTALL#building-perl-outside-of-the-source-directory
afresh1
added a commit
to afresh1/OpenBSD-perl
that referenced
this pull request
Nov 16, 2024
afresh1
added a commit
to afresh1/OpenBSD-perl
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Cwd::abs_path resolves symlinks, it means if we are in PERL_CORE and building perl outside of the source directory, whle the main source directory is readonly, some of the tests fail because they can't write to the source directory when they should be writing to the build directory, or ideally to a tmpdir.
https://github.com/Perl/perl5/blob/blead/INSTALL#building-perl-outside-of-the-source-directory
We use this feature in OpenBSD.