Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tester helpers as github actions as well #20

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

happy-barney
Copy link
Contributor

so even people who doesn't use perldocker/perl-tester images can use these tools

@oalders
Copy link
Member

oalders commented Jan 2, 2024

I didn't realize we were still on a master branch. Now seems like a good time to rename to main before we merge this.

@@ -0,0 +1,10 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might read more naturally as install-helper-deps or even, more explicitly, as install-test-helper-deps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, choosing later

Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea. Just had a couple of comments. I think we can rename the default branch without anything breaking, since I don't believe that anything outside of this PR relies on a specific name.

@happy-barney
Copy link
Contributor Author

Updated, expecting main in README (master is mentioned there in direct uri)

Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@oalders oalders merged commit 22d1146 into perl-actions:main Jan 3, 2024
2 checks passed
@happy-barney happy-barney deleted the hpb/actionify branch January 3, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants