Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the format of the solution file to allow the source of extras … #80

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

sputt
Copy link
Collaborator

@sputt sputt commented Jun 22, 2024

…to be preserved.

A new format in the explanation clause provides a [] delimited extra that supplied the requirement. For example, if cryptography was provided by the "security" extra from the requests library and your project required requests[security], the lines would now appear as:

myproject==1.0
requests==2.0  # myproject (>=2 [security])
cryptography==1.0.0  # requests[security] (>=1)

The extra marker is required to build the dependency tree back exactly.

This fixes #79

@sputt sputt requested a review from abrisco June 22, 2024 17:58
…to be preserved.

A new format in the explanation clause provides a [] delimited extra that supplied
the requirement. For example, if cryptography was provided by the "security" extra
from the requests library and your project required requests[security], the lines
would now appear as:

    myproject==1.0
    requests==2.0  # myproject (>=2 [security])
    cryptography==1.0.0  # requests[security] (>=1)

The extra marker is required to build the dependency tree back exactly. Additionally,
a new flag --remove-constraints will allow easy refreshing of solution files, by removing
the pins they provide when passed via --constraints, producing a solution with the same
versions but refreshed metadata.

This fixes #79
outputs = results[0].build(results[1])
outputs = sorted(outputs, key=lambda x: x.name)
return set(str(req) for req in outputs)
def _real_outputs(results: Tuple[DistributionCollection, Set[DependencyNode]]):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this format?

@abrisco abrisco merged commit bd9d7cb into master Jun 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental re-comiples produce different results
2 participants