Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix for PERCY_GZIP flag #1842

Merged
merged 4 commits into from
Jan 10, 2025
Merged

🐛 fix for PERCY_GZIP flag #1842

merged 4 commits into from
Jan 10, 2025

Conversation

prklm10
Copy link
Contributor

@prklm10 prklm10 commented Jan 10, 2025

Issue ->
We are facing error when PERCY_GZIP is set to true.
There is some race condition where we are zipping already zipped content.
I was not able to fix the race condition but i have found a workaround for this.
How to reproduce it
Snapshot.yml

- name: abc
  url: https://percy.io/integrations
- name: abc1
  url: https://percy.io/integrations
- name: abc2
  url: https://percy.io/integrations

PERCY_GZIP=true
It will fail 3/10 time with error [percy:core] TypeError: Cannot read properties of undefined (reading 'url')
Some of the content are already zipped and
Fixed build https://percy.io/9560f98d/web/pradum-debugging-9d5722f8/builds/38137551

@prklm10 prklm10 requested a review from a team as a code owner January 10, 2025 08:59
@prklm10 prklm10 changed the title :bug fix for gzip 🐛 fix for PERCY_GZIP flag Jan 10, 2025
Copy link
Contributor

@pankaj443 pankaj443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prklm10 prklm10 merged commit 20b4d94 into master Jan 10, 2025
36 checks passed
@prklm10 prklm10 deleted the PER-4268 branch January 10, 2025 09:53
@prklm10 prklm10 added the 🐛 bug Something isn't working label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants